nalalangan/costco-grocery-list
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: align legacy list controller with sendError

Browse Source
This commit is contained in:
Nico 2026-02-16 01:27:35 -08:00
parent 2a9389532f
commit 16e60dcf63
1 changed files with 22 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
backend/controllers/lists.controller.js
View File

@ -1,5 +1,6 @@
const List = require("../models/list.model"); const List = require("../models/list.model");
const { isValidItemType, isValidItemGroup, isValidZone } = require("../constants/classifications"); const { isValidItemType, isValidItemGroup, isValidZone } = require("../constants/classifications");
const { sendError } = require("../utils/http");
exports.getList = async (req, res) => { exports.getList = async (req, res) => {
@ -57,9 +58,9 @@ exports.updateItemImage = async (req, res) => {
const imageBuffer = req.processedImage?.buffer || null; const imageBuffer = req.processedImage?.buffer || null;
const mimeType = req.processedImage?.mimeType || null; const mimeType = req.processedImage?.mimeType || null;
if (!imageBuffer) { if (!imageBuffer) {
return res.status(400).json({ message: "No image provided" }); return sendError(res, 400, "No image provided");
} }
// Update the item with new image // Update the item with new image
await List.addOrUpdateItem(itemName, quantity, userId, imageBuffer, mimeType); await List.addOrUpdateItem(itemName, quantity, userId, imageBuffer, mimeType);
@ -89,17 +90,17 @@ exports.updateItemWithClassification = async (req, res) => {
const { item_type, item_group, zone } = classification; const { item_type, item_group, zone } = classification;
// Validate classification data // Validate classification data
if (item_type && !isValidItemType(item_type)) { if (item_type && !isValidItemType(item_type)) {
return res.status(400).json({ message: "Invalid item_type" }); return sendError(res, 400, "Invalid item_type");
} }
if (item_group && !isValidItemGroup(item_type, item_group)) { if (item_group && !isValidItemGroup(item_type, item_group)) {
return res.status(400).json({ message: "Invalid item_group for selected item_type" }); return sendError(res, 400, "Invalid item_group for selected item_type");
} }
if (zone && !isValidZone(zone)) { if (zone && !isValidZone(zone)) {
return res.status(400).json({ message: "Invalid zone" }); return sendError(res, 400, "Invalid zone");
} }
// Upsert classification with confidence=1.0 and source='user' // Upsert classification with confidence=1.0 and source='user'
await List.upsertClassification(id, { await List.upsertClassification(id, {
@ -112,8 +113,8 @@ exports.updateItemWithClassification = async (req, res) => {
} }
res.json({ message: "Item updated successfully" }); res.json({ message: "Item updated successfully" });
} catch (error) { } catch (error) {
console.error("Error updating item with classification:", error); console.error("Error updating item with classification:", error);
res.status(500).json({ message: "Failed to update item" }); sendError(res, 500, "Failed to update item");
} }
}; };