From 24f2283cafc9d6d7420b393fd6bc847e3424e375 Mon Sep 17 00:00:00 2001 From: Nico Date: Thu, 4 Jun 2026 01:18:01 -0700 Subject: [PATCH] fix: remove duplicate map edit action --- frontend/src/components/maps/LocationMapBottomSheet.jsx | 5 ----- frontend/src/pages/LocationMapManager.jsx | 1 - frontend/tests/location-map-manager.spec.ts | 7 ++++--- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/frontend/src/components/maps/LocationMapBottomSheet.jsx b/frontend/src/components/maps/LocationMapBottomSheet.jsx index 230d0d7..70e1bcf 100644 --- a/frontend/src/components/maps/LocationMapBottomSheet.jsx +++ b/frontend/src/components/maps/LocationMapBottomSheet.jsx @@ -47,7 +47,6 @@ export default function LocationMapBottomSheet({ onPreviewDraft, onPanMode, onEditObjects, - onEditMode, onObjectField, onZoneLinkChange, onClearSelection, @@ -143,10 +142,6 @@ export default function LocationMapBottomSheet({ {primaryDraftActions} {secondaryDraftActions} - ) : canManage && mapState?.published_map ? ( -
- -
) : null; return ( diff --git a/frontend/src/pages/LocationMapManager.jsx b/frontend/src/pages/LocationMapManager.jsx index 034e93f..f30afe3 100644 --- a/frontend/src/pages/LocationMapManager.jsx +++ b/frontend/src/pages/LocationMapManager.jsx @@ -619,7 +619,6 @@ export default function LocationMapManager() { onPreviewDraft={handlePreviewDraft} onPanMode={() => setEditorTool("pan")} onEditObjects={() => setEditorTool("edit")} - onEditMode={handleEditMode} onObjectField={handleObjectField} onZoneLinkChange={handleZoneLinkChange} onClearSelection={() => setSelectedObjectKey(null)} diff --git a/frontend/tests/location-map-manager.spec.ts b/frontend/tests/location-map-manager.spec.ts index 5b34b23..ab78e90 100644 --- a/frontend/tests/location-map-manager.spec.ts +++ b/frontend/tests/location-map-manager.spec.ts @@ -360,7 +360,8 @@ test("admin creates a map from zones, saves a draft, and publishes it", async ({ await page.getByRole("button", { name: "Publish", exact: true }).click(); await expect(page.locator(".location-map-status")).toHaveText("Published"); - await expect(page.getByRole("button", { name: "Edit Map" })).toBeVisible(); + await expect(page.getByRole("button", { name: "Edit Draft" })).toBeVisible(); + await expect(page.getByRole("button", { name: "Edit Map" })).toHaveCount(0); await expect(page.getByText("loose batteries")).toHaveCount(0); await page.locator(".location-map-object", { hasText: "Bread Wall" }).locator("rect").first().click(); @@ -1250,7 +1251,7 @@ test("admin publish saves pending map edits before publishing", async ({ page }) await page.goto("/stores/100/locations/10/map"); - await page.getByRole("button", { name: "Edit Map" }).click(); + await page.getByRole("button", { name: "Edit Draft" }).click(); await page.getByRole("button", { name: "Edit Objects" }).click(); await page.locator(".location-map-object", { hasText: "Live Bakery" }).locator("rect").first().click(); await page.getByRole("textbox", { name: "Label" }).fill("Quick Publish Bakery"); @@ -1332,7 +1333,7 @@ test("admin publish failure keeps successfully saved pending edits", async ({ pa await page.goto("/stores/100/locations/10/map"); - await page.getByRole("button", { name: "Edit Map" }).click(); + await page.getByRole("button", { name: "Edit Draft" }).click(); await page.getByRole("button", { name: "Edit Objects" }).click(); await page.locator(".location-map-object", { hasText: "Live Bakery" }).locator("rect").first().click(); await page.getByRole("textbox", { name: "Label" }).fill("Saved Draft Bakery");