From 771436b4caf1ca63a0e388e9bfe2cf339d626352 Mon Sep 17 00:00:00 2001 From: Nico Date: Thu, 4 Jun 2026 22:12:47 -0700 Subject: [PATCH] fix: simplify map edit controls --- .../maps/LocationMapBottomSheet.jsx | 13 +++---- .../src/components/maps/LocationMapCanvas.jsx | 7 ++-- .../components/maps/LocationMapToolbar.jsx | 26 ------------- .../src/hooks/useLocationMapDraftActions.js | 10 ++--- .../src/hooks/useLocationMapDraftState.js | 6 +-- .../src/hooks/useLocationMapObjectActions.js | 7 +--- .../src/hooks/useLocationMapViewControls.js | 20 +--------- frontend/src/pages/LocationMapManager.jsx | 12 ------ .../src/styles/pages/LocationMapManager.css | 24 ------------ frontend/tests/location-map-manager.spec.ts | 38 ++----------------- 10 files changed, 20 insertions(+), 143 deletions(-) diff --git a/frontend/src/components/maps/LocationMapBottomSheet.jsx b/frontend/src/components/maps/LocationMapBottomSheet.jsx index 05bd701..dd7fb39 100644 --- a/frontend/src/components/maps/LocationMapBottomSheet.jsx +++ b/frontend/src/components/maps/LocationMapBottomSheet.jsx @@ -17,7 +17,6 @@ const EMPTY_ITEMS = []; export default function LocationMapBottomSheet({ mode, - editorTool, canManage, filters, setFilters, @@ -72,17 +71,15 @@ export default function LocationMapBottomSheet({ ? `${selectedZoneItems.length} shown` : `${selectedZoneItems.length} item${selectedZoneItems.length === 1 ? "" : "s"}`; const sheetTitle = mode === "edit" - ? selectedObject && editorTool === "edit" + ? selectedObject ? selectedTitle - : editorTool === "edit" - ? "Edit Areas" - : "Move Map" + : "Edit Areas" : selectedObject ? selectedTitle : "Map Details"; const showHeaderItemCount = mode !== "edit" && Boolean(selectedObject); const showEditorControls = mode === "edit" && canManage; - const showSelectedObjectForm = Boolean(mode === "edit" && editorTool === "edit" && selectedObject); + const showSelectedObjectForm = Boolean(mode === "edit" && selectedObject); const showUnmappedPanel = filters.showUnmapped && !selectedObject; useEffect(() => { @@ -106,7 +103,7 @@ export default function LocationMapBottomSheet({ () => mapObjects.filter((object) => !objectZoneId(object)).length, [mapObjects] ); - const showDraftOverview = mode === "edit" && editorTool === "edit" && !selectedObject; + const showDraftOverview = mode === "edit" && !selectedObject; const draftOverviewRows = [ { label: "Areas", value: totalAreaCount }, ...(hiddenAreaCount > 0 ? [{ label: "Hidden", value: hiddenAreaCount }] : []), @@ -275,7 +272,7 @@ export default function LocationMapBottomSheet({ /> ) : null} - {mode === "edit" && editorTool === "edit" && selectedObject ? ( + {mode === "edit" && selectedObject ? ( 0 && !filters.showZones; const visibleObjectCount = filters.showZones ? objects.filter((object) => object.visible).length @@ -298,7 +297,7 @@ export default function LocationMapCanvas({ className={[ "location-map-canvas-shell", mode === "edit" ? "is-edit-mode" : "is-view-mode", - editorTool === "edit" ? "is-object-tool" : "is-pan-tool", + mode === "edit" ? "is-object-tool" : "is-pan-tool", isPanning ? "is-panning" : "", ].filter(Boolean).join(" ")} > diff --git a/frontend/src/components/maps/LocationMapToolbar.jsx b/frontend/src/components/maps/LocationMapToolbar.jsx index 7e546ec..c0a542c 100644 --- a/frontend/src/components/maps/LocationMapToolbar.jsx +++ b/frontend/src/components/maps/LocationMapToolbar.jsx @@ -48,7 +48,6 @@ function ToolbarIcon({ name }) { export default function LocationMapToolbar({ mode, - editorTool, hasAnyMap, canManage, saving, @@ -59,8 +58,6 @@ export default function LocationMapToolbar({ onFit, onView, onEdit, - onPanMode, - onEditObjects, onUndo, onRedo, }) { @@ -126,29 +123,6 @@ export default function LocationMapToolbar({ ) : null} - {mode === "edit" && canManage ? ( -
- - -
- ) : null} -