nalalangan/grocery-app
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Move store zones and locations into modals #11

Merged
nalalangan merged 1 commits from feature/store-management-modals into feature-custom-store-locations 2026-05-31 17:47:17 -09:00
Conversation 0 Commits 1 Files Changed 6 +1119 -336
nalalangan commented 2026-05-31 17:46:23 -09:00
Owner
Copy Link

Owner: Codex
Status: review
Branch: feature/store-management-modals
Branch relationship: stacked on parent branch feature-custom-store-locations
Likely modified areas: store management UI, shared management modal styling, focused Playwright coverage
Actual modified files: docs/guides/management-modal-patterns.md; frontend/src/components/manage/ManageStores.jsx; frontend/src/components/manage/StoreLocationManager.jsx; frontend/src/components/manage/StoreZoneManager.jsx; frontend/src/styles/components/manage/ManageStores.css; frontend/tests/available-items-catalog.spec.ts
Collision risk: medium
Last meaningful update: 2026-05-31 - implemented modal-based location and zone management and reran frontend checks

Summary:

  • Moves store location add/edit/default/delete actions into a Manage Locations modal using the same row-click settings and bulk delete pattern as store item management.
  • Moves zone add/edit/reorder/delete actions into a Manage Zones modal with row-click settings and slide-confirm bulk deletion.
  • Keeps the main store cards focused on location summaries plus modal entry points, and documents the shared management modal pattern.
  • Adds focused Playwright coverage for location and zone modal flows.

Tests:

  • npm run lint
  • npm run typecheck
  • npm run build:frontend
  • PLAYWRIGHT_BASE_URL=http://127.0.0.1:3910 npm run test:e2e -- available-items-catalog.spec.ts

Notes:

  • Frontend build passes, with the existing Vite warning that Node.js 20.13.1 is below the preferred 20.19+ or 22.12+ range.
Owner: Codex Status: review Branch: feature/store-management-modals Branch relationship: stacked on parent branch feature-custom-store-locations Likely modified areas: store management UI, shared management modal styling, focused Playwright coverage Actual modified files: docs/guides/management-modal-patterns.md; frontend/src/components/manage/ManageStores.jsx; frontend/src/components/manage/StoreLocationManager.jsx; frontend/src/components/manage/StoreZoneManager.jsx; frontend/src/styles/components/manage/ManageStores.css; frontend/tests/available-items-catalog.spec.ts Collision risk: medium Last meaningful update: 2026-05-31 - implemented modal-based location and zone management and reran frontend checks Summary: - Moves store location add/edit/default/delete actions into a Manage Locations modal using the same row-click settings and bulk delete pattern as store item management. - Moves zone add/edit/reorder/delete actions into a Manage Zones modal with row-click settings and slide-confirm bulk deletion. - Keeps the main store cards focused on location summaries plus modal entry points, and documents the shared management modal pattern. - Adds focused Playwright coverage for location and zone modal flows. Tests: - npm run lint - npm run typecheck - npm run build:frontend - PLAYWRIGHT_BASE_URL=http://127.0.0.1:3910 npm run test:e2e -- available-items-catalog.spec.ts Notes: - Frontend build passes, with the existing Vite warning that Node.js 20.13.1 is below the preferred 20.19+ or 22.12+ range.
nalalangan added 1 commit 2026-05-31 17:46:23 -09:00
nalalangan merged commit 99d42f6dd0 into feature-custom-store-locations 2026-05-31 17:47:17 -09:00
nalalangan deleted branch feature/store-management-modals 2026-05-31 17:47:17 -09:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nalalangan/grocery-app#11
No description provided.
Delete Branch "feature/store-management-modals"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?