nalalangan/grocery-app
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Flatten store location cards #14

Merged
nalalangan merged 1 commits from feature/flatten-store-location-cards into feature-custom-store-locations 2026-05-31 18:58:20 -09:00
Conversation 0 Commits 1 Files Changed 3 +96 -52
nalalangan commented 2026-05-31 18:57:38 -09:00
Owner
Copy Link

Owner: Codex
Status: review
Branch: feature/flatten-store-location-cards
Branch relationship: stacked on parent branch feature-custom-store-locations
Likely modified areas: store management UI and focused Playwright coverage
Actual modified files: frontend/src/components/manage/ManageStores.jsx; frontend/src/styles/components/manage/ManageStores.css; frontend/tests/available-items-catalog.spec.ts
Collision risk: medium
Last meaningful update: 2026-05-31 - flattened nested location cards and reran frontend checks

Summary:

  • Removes the nested card treatment from store locations so locations render as flat rows inside each store card.
  • Moves Manage Locations into the store card header and keeps zone/item controls as compact location-row actions.
  • Hides the repeated location name when a store only has one default location matching the store name.
  • Updates store helper copy to frame locations as map-specific zones, item placement, and shopping order.
  • Adds a focused Playwright assertion for the non-redundant single default location display.

Tests:

  • npm run lint
  • npm run typecheck
  • npm run build:frontend
  • PLAYWRIGHT_BASE_URL=http://127.0.0.1:3910 npm run test:e2e -- available-items-catalog.spec.ts

Notes:

  • Frontend build passes, with the existing Vite warning that Node.js 20.13.1 is below the preferred 20.19+ or 22.12+ range.
  • In-app browser attachment was blocked by the sandbox, so UI validation used focused Playwright coverage.
Owner: Codex Status: review Branch: feature/flatten-store-location-cards Branch relationship: stacked on parent branch feature-custom-store-locations Likely modified areas: store management UI and focused Playwright coverage Actual modified files: frontend/src/components/manage/ManageStores.jsx; frontend/src/styles/components/manage/ManageStores.css; frontend/tests/available-items-catalog.spec.ts Collision risk: medium Last meaningful update: 2026-05-31 - flattened nested location cards and reran frontend checks Summary: - Removes the nested card treatment from store locations so locations render as flat rows inside each store card. - Moves Manage Locations into the store card header and keeps zone/item controls as compact location-row actions. - Hides the repeated location name when a store only has one default location matching the store name. - Updates store helper copy to frame locations as map-specific zones, item placement, and shopping order. - Adds a focused Playwright assertion for the non-redundant single default location display. Tests: - npm run lint - npm run typecheck - npm run build:frontend - PLAYWRIGHT_BASE_URL=http://127.0.0.1:3910 npm run test:e2e -- available-items-catalog.spec.ts Notes: - Frontend build passes, with the existing Vite warning that Node.js 20.13.1 is below the preferred 20.19+ or 22.12+ range. - In-app browser attachment was blocked by the sandbox, so UI validation used focused Playwright coverage.
nalalangan added 1 commit 2026-05-31 18:57:38 -09:00
nalalangan merged commit 8387e22b4f into feature-custom-store-locations 2026-05-31 18:58:20 -09:00
nalalangan deleted branch feature/flatten-store-location-cards 2026-05-31 18:58:20 -09:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nalalangan/grocery-app#14
No description provided.
Delete Branch "feature/flatten-store-location-cards"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?