nalalangan/grocery-app
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Remove default location card label #17

Merged
nalalangan merged 1 commits from feature/remove-default-location-label into feature-custom-store-locations 2026-05-31 19:30:07 -09:00
Conversation 0 Commits 1 Files Changed 2 +1 -4
nalalangan commented 2026-05-31 19:29:39 -09:00
Owner
Copy Link

Owner: Codex
Status: review
Branch: feature/remove-default-location-label
Branch relationship: stacked on parent branch feature-custom-store-locations
Likely modified areas: store management UI, manage UI tests
Actual modified files: frontend/src/components/manage/ManageStores.jsx; frontend/tests/available-items-catalog.spec.ts
Collision risk: low
Last meaningful update: 2026-06-01 - Removed the redundant default location label from store cards.

Summary:

  • Removes the default-location label from each store card location row.
  • Keeps default status in the location management modal where it is actionable.
  • Updates focused Playwright coverage to prevent the redundant label from returning.

Tests:

  • npm run lint
  • npm run typecheck
  • PLAYWRIGHT_BASE_URL=http://127.0.0.1:3922 npm run test:e2e -- available-items-catalog.spec.ts
  • npm run build:frontend

Notes:

  • Frontend build completed, but Vite warned the shell Node.js version is 20.13.1 while the project expects 20.19+ or 22.12+.
  • In-app browser verification was blocked by the existing Windows sandbox startup failure; focused Playwright coverage passed.
Owner: Codex Status: review Branch: feature/remove-default-location-label Branch relationship: stacked on parent branch feature-custom-store-locations Likely modified areas: store management UI, manage UI tests Actual modified files: frontend/src/components/manage/ManageStores.jsx; frontend/tests/available-items-catalog.spec.ts Collision risk: low Last meaningful update: 2026-06-01 - Removed the redundant default location label from store cards. Summary: - Removes the default-location label from each store card location row. - Keeps default status in the location management modal where it is actionable. - Updates focused Playwright coverage to prevent the redundant label from returning. Tests: - npm run lint - npm run typecheck - PLAYWRIGHT_BASE_URL=http://127.0.0.1:3922 npm run test:e2e -- available-items-catalog.spec.ts - npm run build:frontend Notes: - Frontend build completed, but Vite warned the shell Node.js version is 20.13.1 while the project expects 20.19+ or 22.12+. - In-app browser verification was blocked by the existing Windows sandbox startup failure; focused Playwright coverage passed.
nalalangan added 1 commit 2026-05-31 19:29:40 -09:00
nalalangan merged commit d94a169417 into feature-custom-store-locations 2026-05-31 19:30:07 -09:00
nalalangan deleted branch feature/remove-default-location-label 2026-05-31 19:30:07 -09:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nalalangan/grocery-app#17
No description provided.
Delete Branch "feature/remove-default-location-label"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?