nalalangan/grocery-app
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Move member actions into a modal #6

Merged
nalalangan merged 1 commits from feature/member-actions-modal into feature-custom-store-locations 2026-05-31 16:07:50 -09:00
Conversation 0 Commits 1 Files Changed 3 +221 -56
nalalangan commented 2026-05-31 16:07:17 -09:00
Owner
Copy Link

Owner: Codex
Status: review
Branch: feature/member-actions-modal
Branch relationship: stacked on parent branch feature-custom-store-locations
Likely modified areas: Manage household member UI, manage household styles, Playwright household management tests
Actual modified files: frontend/src/components/manage/ManageHousehold.jsx; frontend/src/styles/components/manage/ManageHousehold.css; frontend/tests/invite-link-management.spec.ts
Collision risk: medium
Last meaningful update: 2026-05-31 - moved member role/removal actions into a click/tap modal and verified focused Manage tests.

Summary:

  • Removes inline role and removal buttons from member cards.
  • Opens member actions in a modal when a member card is clicked or tapped.
  • Keeps the existing slide confirmation flow for ownership transfer, role changes, and removals.
  • Updates focused Playwright coverage and current household store/location mocks.

Tests run:

  • npm run lint
  • npm run typecheck
  • npm run build:frontend
  • PLAYWRIGHT_BASE_URL=http://127.0.0.1:3910 npm run test:e2e -- invite-link-management.spec.ts
Owner: Codex Status: review Branch: feature/member-actions-modal Branch relationship: stacked on parent branch feature-custom-store-locations Likely modified areas: Manage household member UI, manage household styles, Playwright household management tests Actual modified files: frontend/src/components/manage/ManageHousehold.jsx; frontend/src/styles/components/manage/ManageHousehold.css; frontend/tests/invite-link-management.spec.ts Collision risk: medium Last meaningful update: 2026-05-31 - moved member role/removal actions into a click/tap modal and verified focused Manage tests. Summary: - Removes inline role and removal buttons from member cards. - Opens member actions in a modal when a member card is clicked or tapped. - Keeps the existing slide confirmation flow for ownership transfer, role changes, and removals. - Updates focused Playwright coverage and current household store/location mocks. Tests run: - npm run lint - npm run typecheck - npm run build:frontend - PLAYWRIGHT_BASE_URL=http://127.0.0.1:3910 npm run test:e2e -- invite-link-management.spec.ts
nalalangan added 1 commit 2026-05-31 16:07:17 -09:00
nalalangan merged commit cb38b051b3 into feature-custom-store-locations 2026-05-31 16:07:50 -09:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nalalangan/grocery-app#6
No description provided.
Delete Branch "feature/member-actions-modal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?