nalalangan/grocery-app
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Compact store delete count label #10

Merged
nalalangan merged 1 commits from feature/compact-store-delete-label into feature-custom-store-locations 2026-05-31 17:23:00 -09:00
Conversation 0 Commits 1 Files Changed 3 +6 -6
nalalangan commented 2026-05-31 17:22:28 -09:00
Owner
Copy Link

Owner: Codex
Status: review
Branch: feature/compact-store-delete-label
Branch relationship: stacked on parent branch feature-custom-store-locations
Likely modified areas: Store item manager modal label, focused Playwright catalog modal test, management modal docs
Actual modified files: docs/guides/management-modal-patterns.md; frontend/src/components/manage/StoreAvailableItemsManager.jsx; frontend/tests/available-items-catalog.spec.ts
Collision risk: low
Last meaningful update: 2026-05-31 - shortened the delete confirmation count label to fit the mobile modal.

Summary:

  • Changes delete mode button text from Confirm Delete (# selected) to Confirm Delete (#).
  • Updates the focused catalog modal test expectations.
  • Updates the management modal pattern docs to match the compact label.

Tests run:

  • npm run lint
  • npm run typecheck
  • npm run build:frontend
  • PLAYWRIGHT_BASE_URL=http://127.0.0.1:3910 npm run test:e2e -- available-items-catalog.spec.ts

Notes:

  • Vite build completed with the existing Node version warning: Node.js 20.13.1 is below Vite's recommended 20.19+ or 22.12+.
Owner: Codex Status: review Branch: feature/compact-store-delete-label Branch relationship: stacked on parent branch feature-custom-store-locations Likely modified areas: Store item manager modal label, focused Playwright catalog modal test, management modal docs Actual modified files: docs/guides/management-modal-patterns.md; frontend/src/components/manage/StoreAvailableItemsManager.jsx; frontend/tests/available-items-catalog.spec.ts Collision risk: low Last meaningful update: 2026-05-31 - shortened the delete confirmation count label to fit the mobile modal. Summary: - Changes delete mode button text from `Confirm Delete (# selected)` to `Confirm Delete (#)`. - Updates the focused catalog modal test expectations. - Updates the management modal pattern docs to match the compact label. Tests run: - npm run lint - npm run typecheck - npm run build:frontend - PLAYWRIGHT_BASE_URL=http://127.0.0.1:3910 npm run test:e2e -- available-items-catalog.spec.ts Notes: - Vite build completed with the existing Node version warning: Node.js 20.13.1 is below Vite's recommended 20.19+ or 22.12+.
nalalangan added 1 commit 2026-05-31 17:22:28 -09:00
nalalangan merged commit ce04ac6951 into feature-custom-store-locations 2026-05-31 17:23:00 -09:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nalalangan/grocery-app#10
No description provided.
Delete Branch "feature/compact-store-delete-label"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?