nalalangan/grocery-app
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Add grocery store and location selectors #19

Open
nalalangan wants to merge 2 commits from feature/store-selector-modal into feature-custom-store-locations
pull from: feature/store-selector-modal
merge into: nalalangan:feature-custom-store-locations
Conversation 0 Commits 2 Files Changed 4 +591 -70
nalalangan commented 2026-06-01 22:29:15 -09:00
Owner
Copy Link

Owner: Codex
Status: review
Branch: feature/store-selector-modal
Branch relationship: stacked on feature-custom-store-locations
Likely modified areas: grocery store/location selectors, store context persistence, selector styling, Playwright coverage
Actual modified files: frontend/src/components/store/StoreTabs.jsx, frontend/src/context/StoreContext.jsx, frontend/src/styles/components/StoreTabs.css, frontend/tests/store-selector.spec.ts
Collision risk: medium
Last meaningful update: 2026-06-02 - added location selector, map-management navigation, and focused verification

Summary:

  • Replaces the grocery page tab strip with a selected-store button that opens a modal picker only when multiple stores exist.
  • Adds a matching selected-location button below the store selector; it opens a modal picker only when the selected store has multiple locations.
  • Persists the selected location per household and store while preserving the store-level active selection.
  • Adds a compact Manage Map button that routes to the Stores management tab with the current location id in the URL.
  • Adds focused Playwright coverage for store selection, location selection, outside-click modal dismissal, single-option no-op behavior, localStorage persistence, and map navigation.

Tests:

  • npm run lint
  • npm run typecheck
  • git diff --check
  • PLAYWRIGHT_BASE_URL=http://127.0.0.1:3929 npm run test:e2e -- store-selector.spec.ts
  • PLAYWRIGHT_BASE_URL=http://127.0.0.1:3930 npm run test:e2e -- household-selection-persistence.spec.ts
  • npm run build:frontend

Notes:

  • The in-app browser bridge is still blocked in this sandbox by the existing windows sandbox failed: spawn setup refresh startup failure, so live visual inspection through the Codex browser plugin could not be completed.
  • The frontend build passed with the existing Vite warning that Node.js 20.13.1 is below Vite's preferred 20.19+ version.
Owner: Codex Status: review Branch: feature/store-selector-modal Branch relationship: stacked on feature-custom-store-locations Likely modified areas: grocery store/location selectors, store context persistence, selector styling, Playwright coverage Actual modified files: frontend/src/components/store/StoreTabs.jsx, frontend/src/context/StoreContext.jsx, frontend/src/styles/components/StoreTabs.css, frontend/tests/store-selector.spec.ts Collision risk: medium Last meaningful update: 2026-06-02 - added location selector, map-management navigation, and focused verification Summary: - Replaces the grocery page tab strip with a selected-store button that opens a modal picker only when multiple stores exist. - Adds a matching selected-location button below the store selector; it opens a modal picker only when the selected store has multiple locations. - Persists the selected location per household and store while preserving the store-level active selection. - Adds a compact Manage Map button that routes to the Stores management tab with the current location id in the URL. - Adds focused Playwright coverage for store selection, location selection, outside-click modal dismissal, single-option no-op behavior, localStorage persistence, and map navigation. Tests: - npm run lint - npm run typecheck - git diff --check - PLAYWRIGHT_BASE_URL=http://127.0.0.1:3929 npm run test:e2e -- store-selector.spec.ts - PLAYWRIGHT_BASE_URL=http://127.0.0.1:3930 npm run test:e2e -- household-selection-persistence.spec.ts - npm run build:frontend Notes: - The in-app browser bridge is still blocked in this sandbox by the existing `windows sandbox failed: spawn setup refresh` startup failure, so live visual inspection through the Codex browser plugin could not be completed. - The frontend build passed with the existing Vite warning that Node.js 20.13.1 is below Vite's preferred 20.19+ version.
nalalangan added 1 commit 2026-06-01 22:29:15 -09:00
nalalangan added 1 commit 2026-06-01 23:03:24 -09:00
nalalangan changed title from Add grocery store selector modal to Add grocery store and location selectors 2026-06-01 23:05:43 -09:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/store-selector-modal:feature/store-selector-modal
git checkout feature/store-selector-modal
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nalalangan/grocery-app#19
No description provided.
Delete Branch "feature/store-selector-modal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?