nalalangan/grocery-app
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Use grocery placeholder icon in store items #7

Merged
nalalangan merged 1 commits from feature/store-item-placeholder-icon into feature-custom-store-locations 2026-05-31 16:17:17 -09:00
Conversation 0 Commits 1 Files Changed 3 +20 -13
nalalangan commented 2026-05-31 16:16:50 -09:00
Owner
Copy Link

Owner: Codex
Status: review
Branch: feature/store-item-placeholder-icon
Branch relationship: stacked on parent branch feature-custom-store-locations
Likely modified areas: Manage store item catalog modal, store item catalog styles, Playwright catalog modal test
Actual modified files: frontend/src/components/manage/StoreAvailableItemsManager.jsx; frontend/src/styles/components/manage/StoreAvailableItemsManager.css; frontend/tests/available-items-catalog.spec.ts
Collision risk: low
Last meaningful update: 2026-05-31 - replaced letter fallback thumbnails with the grocery-list package placeholder icon and verified the manage catalog modal flow.

Summary:

  • Uses the same package placeholder icon for store catalog items without images.
  • Styles the placeholder thumbnail to match the grocery-list no-image state more closely.
  • Updates the focused catalog modal spec to assert the placeholder and use the current location-scoped API mocks.

Tests run:

  • npm run lint
  • npm run typecheck
  • npm run build:frontend
  • PLAYWRIGHT_BASE_URL=http://127.0.0.1:3910 npm run test:e2e -- available-items-catalog.spec.ts

Notes:

  • The first focused Playwright run failed because this spec still mocked old store-scoped URLs; the mocks were updated to the current location-scoped routes and the rerun passed.
  • In-app browser automation could not connect because the browser bridge exited during startup.
Owner: Codex Status: review Branch: feature/store-item-placeholder-icon Branch relationship: stacked on parent branch feature-custom-store-locations Likely modified areas: Manage store item catalog modal, store item catalog styles, Playwright catalog modal test Actual modified files: frontend/src/components/manage/StoreAvailableItemsManager.jsx; frontend/src/styles/components/manage/StoreAvailableItemsManager.css; frontend/tests/available-items-catalog.spec.ts Collision risk: low Last meaningful update: 2026-05-31 - replaced letter fallback thumbnails with the grocery-list package placeholder icon and verified the manage catalog modal flow. Summary: - Uses the same package placeholder icon for store catalog items without images. - Styles the placeholder thumbnail to match the grocery-list no-image state more closely. - Updates the focused catalog modal spec to assert the placeholder and use the current location-scoped API mocks. Tests run: - npm run lint - npm run typecheck - npm run build:frontend - PLAYWRIGHT_BASE_URL=http://127.0.0.1:3910 npm run test:e2e -- available-items-catalog.spec.ts Notes: - The first focused Playwright run failed because this spec still mocked old store-scoped URLs; the mocks were updated to the current location-scoped routes and the rerun passed. - In-app browser automation could not connect because the browser bridge exited during startup.
nalalangan added 1 commit 2026-05-31 16:16:50 -09:00
nalalangan merged commit eef2c15e8c into feature-custom-store-locations 2026-05-31 16:17:17 -09:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nalalangan/grocery-app#7
No description provided.
Delete Branch "feature/store-item-placeholder-icon"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?