nalalangan/grocery-app
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Simplify store item manager rows #8

Merged
nalalangan merged 1 commits from feature/store-item-manager-cleanup into feature-custom-store-locations 2026-05-31 16:43:56 -09:00
Conversation 0 Commits 1 Files Changed 3 +42 -58
nalalangan commented 2026-05-31 16:43:24 -09:00
Owner
Copy Link

Owner: Codex
Status: review
Branch: feature/store-item-manager-cleanup
Branch relationship: stacked on parent branch feature-custom-store-locations
Likely modified areas: Manage store item catalog modal, store item catalog styles, Playwright catalog modal test
Actual modified files: frontend/src/components/manage/StoreAvailableItemsManager.jsx; frontend/src/styles/components/manage/StoreAvailableItemsManager.css; frontend/tests/available-items-catalog.spec.ts
Collision risk: low
Last meaningful update: 2026-05-31 - simplified the store item manager modal rows and verified the focused catalog modal flow.

Summary:

  • Places the Add Item button inline with the search input in the store item manager modal.
  • Removes redundant per-row labels and the store defaults listing from the item rows.
  • Keeps defaults editable through Edit Settings.
  • Applies a shared action-button sizing class so Edit Settings and Delete Item read consistently.
  • Updates focused Playwright coverage for the simplified modal layout.

Tests run:

  • npm run lint
  • npm run typecheck
  • npm run build:frontend
  • PLAYWRIGHT_BASE_URL=http://127.0.0.1:3910 npm run test:e2e -- available-items-catalog.spec.ts

Notes:

  • Vite build completed with the existing Node version warning: Node.js 20.13.1 is below Vite's recommended 20.19+ or 22.12+.
  • In-app browser automation could not connect because the browser bridge exited during startup.
Owner: Codex Status: review Branch: feature/store-item-manager-cleanup Branch relationship: stacked on parent branch feature-custom-store-locations Likely modified areas: Manage store item catalog modal, store item catalog styles, Playwright catalog modal test Actual modified files: frontend/src/components/manage/StoreAvailableItemsManager.jsx; frontend/src/styles/components/manage/StoreAvailableItemsManager.css; frontend/tests/available-items-catalog.spec.ts Collision risk: low Last meaningful update: 2026-05-31 - simplified the store item manager modal rows and verified the focused catalog modal flow. Summary: - Places the Add Item button inline with the search input in the store item manager modal. - Removes redundant per-row labels and the store defaults listing from the item rows. - Keeps defaults editable through Edit Settings. - Applies a shared action-button sizing class so Edit Settings and Delete Item read consistently. - Updates focused Playwright coverage for the simplified modal layout. Tests run: - npm run lint - npm run typecheck - npm run build:frontend - PLAYWRIGHT_BASE_URL=http://127.0.0.1:3910 npm run test:e2e -- available-items-catalog.spec.ts Notes: - Vite build completed with the existing Node version warning: Node.js 20.13.1 is below Vite's recommended 20.19+ or 22.12+. - In-app browser automation could not connect because the browser bridge exited during startup.
nalalangan added 1 commit 2026-05-31 16:43:25 -09:00
nalalangan merged commit f968d304cc into feature-custom-store-locations 2026-05-31 16:43:56 -09:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nalalangan/grocery-app#8
No description provided.
Delete Branch "feature/store-item-manager-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?